RC-adjustable parameters firmware update

News, Setup, Compiling, Flashing, Development

Re: RC-adjustable parameters firmware update

Postby funth1ngs » Tue Feb 23, 2016 2:06 pm

Nope,

that wasn't the problem. Anywway, It's fixed in config.c with:

Code: Select all
            // create param list in RAM
            for (i = 0; i < CONFIG_NUM_PARAMS; i++) {
                // memcpy(recs[i].name, configParamMeta[i].name, CONFIG_PNAME_MAX_LEN);
                memcpy(recs[i].name, configParamMeta[i].name, strlen(configParamMeta[i].name));


Cheers,
Heiko
funth1ngs
 
Posts: 52
Joined: Tue Jul 03, 2012 3:57 pm

Re: RC-adjustable parameters firmware update

Postby Max » Tue Feb 23, 2016 10:00 pm

OK, found & fixed the crash issue. New builds being posted now, and I'll remove the bad ones from FTP.

7.1.1893 - Feb. 23, 2016 - EXPERIMENTAL (`config_rebase` branch)

* Fix possible crash at startup when updating from an old version or one w/out Quatos params onboard (introduced in 7.1.1891).


Heiko, thanks so much for your help. And also the investigation and fix for the ugly params storage -- I had noticed that at one point but never investigated further since it has been that way for a long time and didn't seem to cause issues. I fixed it with a strncpy() instead, preferring to avoid poking around directly in memory when possible (though in this case it probably doesn't matter).

Cheers,
-Max

PS. It was actually crashing in config.c at
Code: Select all
334: AQ_PRINTF("config: cannot find parmeter '%s'\n", name);

When trying to read past the end of actually used (non-blank) flash memory and therefore the name was an invalid string.
Max
 
Posts: 2814
Joined: Mon Aug 13, 2012 9:45 pm
Location: Near Ithaca, NY, USA

Re: RC-adjustable parameters firmware update

Postby funth1ngs » Wed Feb 24, 2016 8:10 am

Hi Max,

thank you very much for fixing the issue!

Cheers,
Heiko
funth1ngs
 
Posts: 52
Joined: Tue Jul 03, 2012 3:57 pm

Re: RC-adjustable parameters firmware update

Postby Astudillo » Wed Feb 24, 2016 7:31 pm

Hey Guy's

I have problem with the 1893 firmware. I flashed my AQ6Dimu from 1892 to 1893, and when i restored the settings with a param file( that worked fine on 1892) and reboot my FC. All the params are gone except for the RC radio type and throttle scale value. So i started configurating the parameters manually and everything got stored properly if i didn't touch the motor output configuration. So instead of configurating a Hexa X i tried a Quad X and than the params get stored properly. So somewhere between motor 4 and 6 something goes wrong.

Cheers,

Ray
Astudillo
 
Posts: 139
Joined: Thu Apr 25, 2013 8:23 am
Location: Amsterdam, The Netherlands

Re: RC-adjustable parameters firmware update

Postby Max » Wed Feb 24, 2016 8:37 pm

Ray, could you post or PM me your saved params please? The ones that cause the problem. By "gone" do you mean reset to defaults?

Until this is resolved, v1892 is also fine to use if you don't get the immediate crash upon booting. That really would only happen if going from an older vesion with no Quatos params at all, which has only been possible since v1871 anyway.

Thanks,
-Max
Max
 
Posts: 2814
Joined: Mon Aug 13, 2012 9:45 pm
Location: Near Ithaca, NY, USA

Re: RC-adjustable parameters firmware update

Postby Max » Wed Feb 24, 2016 9:22 pm

Folks, if you try the firmware, please post here even if it "just works" and you don't have any issues. It may seem redundant, but this is the only way I can tell how many have actually tried it. Same goes for QGC or whatever else needs to be tested.

Only a few AQ users actually post here at all (I can tell there are a lot more by download counts alone), which is frustrating at times. To those who don't: You're getting many hours of work here given to you for free, the least you could do would be to participate a little. Maybe just say "hi" or "thanks," or "it works here." There is no business, university, sponsors, or other special interests behind what I'm doing, just me. I know for a fact AQ is being used in several university/research projects which obviously have resources far beyond mine, but never hear anything from them.

There may be a misconception that the AQ hardware sales somehow support firmware/software development or end-user support. Or that there is some magical "team" working tirelessly behind the scenes to bring you goodies. That's simply not the case. If you want to see AQ continue to evolve, it's time to chip in. I'm hoping to revive this project a bit after a year in limbo, and any help would be appreciated.

Thanks!
-Max
Max
 
Posts: 2814
Joined: Mon Aug 13, 2012 9:45 pm
Location: Near Ithaca, NY, USA

Re: RC-adjustable parameters firmware update

Postby Astudillo » Wed Feb 24, 2016 9:56 pm

Hi Max,

Well in my opinion you are kind of "Magical" pulling the project the way you do. I'm not a coder and i can only imagine how many hours you put in, but i really appreciate it! of course i can only speak for my self, but ill check out whatever you can throw at me :P I always report when stuffs not working, but ill keep in mind that i will also let you know when it does work. I think thats more than fair.

Oke back to the other post, yes i meant the parameters go back to default if i config the motor outputs.

Here's the Param file.
PARAMSaq6.txt
(14.36 KiB) Downloaded 206 times


Thanks!
Astudillo
 
Posts: 139
Joined: Thu Apr 25, 2013 8:23 am
Location: Amsterdam, The Netherlands

Re: RC-adjustable parameters firmware update

Postby Max » Wed Feb 24, 2016 11:30 pm

Thanks Ray! :)

I think I figured the problem... my fault for rushing the last fix out too quickly. Could you give this one a shot and see if it takes care of the issue? The params in flash should be OK, the problem was when reading them back into RAM.

-Max
Attachments
aqfc-mp-v7.1.1894-hwv6.1-dimu1.1-quatos.zip
(147.91 KiB) Downloaded 181 times
Max
 
Posts: 2814
Joined: Mon Aug 13, 2012 9:45 pm
Location: Near Ithaca, NY, USA

Re: RC-adjustable parameters firmware update

Postby Astudillo » Thu Feb 25, 2016 12:07 am

"Magic" Max your fix like a charm! :)

Thanks!

Ray
Astudillo
 
Posts: 139
Joined: Thu Apr 25, 2013 8:23 am
Location: Amsterdam, The Netherlands

Re: RC-adjustable parameters firmware update

Postby Max » Thu Feb 25, 2016 1:50 am

Thanks for the quick test Ray.

New builds are up on FTP with the fix.

7.1.1894 - Feb. 24, 2016 - EXPERIMENTAL (`config_rebase` branch)

`*` Fix possible issue when loading params from flash storage does not properly overwrite defaults (introduced in 7.1.1893).


Cheers,
-Max
Max
 
Posts: 2814
Joined: Mon Aug 13, 2012 9:45 pm
Location: Near Ithaca, NY, USA

PreviousNext

Return to AQ Firmware

Who is online

Users browsing this forum: No registered users and 2 guests

cron